[CIRCSTORE-387] RequestExpirationService hangs on EventPublisherService exception - FOLIO Issue Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: TBD
Resolution: Done
Affects Version/s: None
Fix Version/s: 16.0.0
Labels:
None

Template:

Standard Bug Write-Up Format
Sprint:
CP: Sprint 154, CP: Sprint 155, CP: Sprint 156
Story Points:
3
Development Team:
Core: Platform
RCA Group:
Implementation coding issue

Description

https://github.com/folio-org/mod-circulation-storage/blob/e94abbbd397f14b1d38912dcf2e8761f98d78516/src/main/java/org/folio/service/RequestExpirationService.java#L74-L85

      .onComplete(v -> {
        if (v.failed()) {
          pgClient.rollbackTx(conn, done -> {
            log.error("Error in request processing", v.cause());
            promise.fail(v.cause());
          });
        } else {
          context.forEach(p -> eventPublisherService
            .publishLogRecord(new JsonObject().put(REQUESTS.value(), p), REQUEST_EXPIRED));
          pgClient.endTx(conn, done -> promise.complete());
        }
      })));

If eventPublisherService.publishLogRecord throws an exception the promise is neither failed nor completed and the request to /scheduled-request-expiration will never get any response. /scheduled-request-expiration is called every 2 minutes. This might be the cause of OKAPI-1141.

TestRail: Results

Attachments

Issue Links

relates to

CIRCSTORE-391 /scheduled-request-expiration hangs on invalid URL or unknown host

Closed

CIRC-1783 Very slow check out behavior observed in Nolana Hotfix #1

In Code Review

OKAPI-1141 In new/old volaris 1/2nd environment unable to create loan policies.

Blocked

Activity

People

Assignee:: Julian Ladisch

Reporter:: Julian Ladisch

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 13/Dec/22 6:59 PM

Updated:: 23/May/23 11:09 AM

Resolved:: 16/Jan/23 9:58 PM

RequestExpirationService hangs on EventPublisherService exception