Uploaded image for project: 'mod-circulation-storage'
  1. mod-circulation-storage
  2. CIRCSTORE-377

Schema name should not be embedded in sql function body

    XMLWordPrintable

Details

    • Bug
    • Status: Open (View Workflow)
    • P3
    • Resolution: Unresolved
    • None
    • None
    • None
    • Vega
    • Poppy (R2 2023)
    • TBD

    Description

      Please check if ${myuniversity}_${mymodule} before normalize_digits can/should be removed. See https://github.com/folio-org/mod-circulation-storage/blob/v15.0.1/src/main/resources/templates/db_scripts/createIsbnFunctions.sql#L5

      CREATE OR REPLACE FUNCTION ${myuniversity}_${mymodule}.normalize_isbns(jsonb_array jsonb) RETURNS text AS $$
  SELECT string_agg(${myuniversity}_${mymodule}.normalize_digits(identifiers->>'value'), ' ')
  FROM jsonb_array_elements($1) as identifiers
  WHERE identifiers->>'identifierTypeId' = '8261054f-be78-422d-bd51-4ed9f33c3422';
$$ LANGUAGE sql IMMUTABLE PARALLEL SAFE STRICT;

      TestRail: Results

        Attachments

          Issue Links

            relates to

            Task - A task that needs to be done. CIRCSTORE-389 [SPIKE] Review SQL scripts, find functions with hardcoded schema name

            • TBD - To be determined
            • Open

            Bug - A problem which impairs or prevents the functions of the product. MODINVSTOR-993 Schema name should not be embedded in sql function body

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Draft

            Activity

              People

                Unassigned Unassigned
                hji Hongwei Ji
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:

                  TestRail: Runs

                    TestRail: Cases