Uploaded image for project: 'mod-circulation-storage'
  1. mod-circulation-storage
  2. CIRCSTORE-191

Review and Possibly Replace HttpURLConnection with HttpStatus enums

    XMLWordPrintable

Details

    • Task
    • Status: Open (View Workflow)
    • TBD
    • Resolution: Unresolved
    • None
    • None
    • None

    Description

      I am suggesting to review the usage of HttpURLConnection for HTTP Status codes, like the one below.

      HttpURLConnection.HTTP_CREATED
      

      That is fine with normal HTTP requests, but if these requests are associated with Okapi, then the Okapi-specific variant HttpStatus should instead be used.

      HttpStatus.HTTP_CREATED
      

      There may be some work already done in this regards in ticket CIRCSTORE-183.
      (HttpResponseStatusCodeMatchers.java may potentially be replacabled with OkapiResponseStatusCodeMatchers.java from CIRCSTORE-183.)

      There are also some tests that use integers, such as the use of 200 instead of HttpStatus.HTTP_OK.

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                kday Kevin Day
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:

                  TestRail: Runs

                    TestRail: Cases