Uploaded image for project: 'mod-circulation-storage'
  1. mod-circulation-storage
  2. CIRCSTORE-188

Update UUIDValidation, consider using $ref in loan-policy.json

    XMLWordPrintable

Details

    • EPAM-Veg Sprint 140
    • 0.5
    • Vega

    Description

      UUIDValidation.java may be using incorrect validation logic.

      "^[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}$"
      

      may instead be something more like

      "^[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[1-5][a-fA-F0-9]{3}-[89abAB][a-fA-F0-9]{3}-[a-fA-F0-9]{12}$"
      

      Or it could be that uuid.schema (which uses the second case above) to be incorrect.

      Also consider adding the following to loan-policy.json

      "$ref": "raml-util/schemas/uuid.schema"
      

      as discussed:
      https://github.com/folio-org/mod-circulation-storage/pull/232#discussion_r374000520

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                kday Kevin Day
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases