Hold shelf expiration time should be 11:59 when specified in days, weeks or months

User story:
As a patron who has a request awaiting pickup for at least a day
I want the request to remain on the hold shelf until the end of the pickup day
So I don't come into the library only to find my requested item has been loaned to someone else

As a patron who has a request awaiting pickup for minutes or hours (usually used only for short term loan items)
I want the request to remain on the hold shelf only until the date and time the request expires
So the request doesn't sit on the hold shelf too long when others may want to borrow it

Scenarios:

1. Scenario
   • Given Request R's pickup service point has its hold shelf expiration period specified in days, weeks or months
   • When the request is checked in at the pickup service point and the status is changed to "Open - Awaiting pickup"
   • Then:
     • The request's Hold Shelf Expiration Date in the Request record should be populated with today's date /time plus the Hold shelf expiration period defined in the Service point
     • If expiration time needs to be stored, it should be 11:59 pm (this would be consistent with the due time given to loans where the loan period is specified in days, weeks or months)
2. Scenario CB: Note this is already how expiration works
   • Given Request R's pickup service point has its hold shelf expiration period specified in minutes or hours
   • When the request is checked in at the pickup service point and the status is changed to "Open - Awaiting pickup"
   • Then the request's Hold Shelf Expiration Date in the Request record should be populated with today's date/time plus the Hold shelf expiration period defined in the Service point

--------------------------------------
From Chalmers issue: CHAL-128:
When setting Hold shelf expiration period to 7 days

Expected: Item is on the Hold shelf clearance report after the seventh day have passed

Actual: Item is on the Hold shelf clearance report after 7 x 24 hours making it hard for both staff and patrons to understand when they should pick up the item at the latest.