Uploaded image for project: 'mod-circulation'
  1. mod-circulation
  2. CIRC-467

Back end work for UICIRC-341: add lost item fee policy in circulation rules syntax



    • Core: F - Sprint 57, Concorde - Sprint 76, Concorde - Sprint 77
    • 5
    • Concorde


      When Holly cloned UICIRC-187 she was unable to clear the values in the Sprint field!

      This is an extension of issue CIRC-187: Back end work for UICIRC-164 and UICIRC-165: Include request policy and patron notice policy in circulation rules syntax. In UICIRC-187, Request and Notice policies were added to circ rules syntax. At that time Holly thought the fee/fine policies would be added as well, but they were not. The lack of these policies in the circ rules is now holding up Fees/Fines work.

      At this time we need to add overdue fine policy and lost item fee policy circulation rules syntax. UICIRC-341 only defines the editor behavior for defining the new rules syntax, and does not cover application of those rules.

      Holly has cloned the original UICIRC-187 backend user story. The author of that User Story was concerned "whether this scope seems correct" and whether "this is sufficient elaboration (pre-grooming) for a backend story." I recommend that the Assignee read the original JIRA Description and Comments.

      Below you will find the original user story author's Description with minor changes to refer to the new policies. This information could be incorrect. Check with Ryan Laddusaw, the dev who worked on CIRC-187.


      • Loan rules API should treat the new format as valid
      • Loan rules API will evaluate the loan rules to determine a loan policy
      • Loan rules API will not evaluate the loan rules to determine a overdue fine or lost item fee policies

      Technical Scope

      • Rename the API endpoints associated with loan rules to be circulation rules instead, to reflect the broader usage
      • Provide circulation 6.0 interface
      • Depend upon circulation-rules-storage 1.0 instead of loan-rules-storage 1.0


      • Given that the rules format is changing, this is a major behavioral change (we may need a decision on FOLIO-1746 prior to merge).
      • Given the broader usage of these rules and the clarification that the domain terminology is circulation-rules a major interface breaking change will also occur to reflect that

      Technical Background

      • The loan rules are parsed using Antlr to generate a Drools rules definition which is stored and then used during evaluation.
      • The loan rules application needs to have an API endpoint for each policy type that is needed. Currently there should be three API endpoints, one each for loan, request and patron notice policies.

      TestRail: Results


          Issue Links



                VRohach Volodymyr Rohach
                hollyolepm Holly Mistlebauer
                0 Vote for this issue
                14 Start watching this issue



                  TestRail: Runs

                    TestRail: Cases