Uploaded image for project: 'mod-circulation'
  1. mod-circulation
  2. CIRC-165

Incorrect related record queries query parameter

    XMLWordPrintable

Details

    Description

      Some related record queries when fetching requests do not provide a named query CQL parameter, instead this is provided as the whole query string itself (see example below).

      FOLIO collection endpoints typically ignore unexpected query string parameters, and hence treat this as a request for all records. Within small record sets, this makes this difficult to identify, as the expected records are likely found within the first page of all records, and so don't demonstrate unintended behaviour.

      This is compounded by the CollectionResourceClient providing a method that accepts a raw query parameter string in it's entirety. This is intended for forwarding of the query string parameters sent by the client directly to storage without needing to parse and re-encode them.

      This method will be renamed (and described as deprecated) during this fix, a later change is needed to parse the expected incoming parameters (query, offset and limit) and pass only them on explicitly.

      GET http://localhost:9493/service-points?id%3D%3Dcbd124f2-8d39-4406-88e1-a10300e0cceb+OR+id%3D%3Dcbd124f2-8d39-4406-88e1-a10300e0cceb+OR+id%3D%3Dcffbfcb1-2fc6-4fe6-bfd2-01291162add7+OR+id%3D%3Dcffbfcb1-2fc6-4fe6-bfd2-01291162add7+OR+id%3D%3Dcbd124f2-8d39-4406-88e1-a10300e0cceb+OR+id%3D%3Dcbd124f2-8d39-4406-88e1-a10300e0cceb+OR+id%3D%3Dcffbfcb1-2fc6-4fe6-bfd2-01291162add7
      

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                marcjohnson Marc Johnson
                marcjohnson Marc Johnson
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases