Uploaded image for project: 'mod-circulation'
  1. mod-circulation
  2. CIRC-1421

During check-in only update fulfillable request if it's for the same item

    XMLWordPrintable

Details

    • Story
    • Status: Closed (View Workflow)
    • TBD
    • Resolution: Done
    • None
    • 23.0.0
    • None
    • EPAM-Veg Sprint 132
    • 2
    • Vega
    • Lotus R1 2022
    • TBD

    Description

      NPE thrown when an item is checked in and there are fulfillable requests in the unified queue (TLR is enabled), but they are not fulfillable by the item that is checked in:

      java.lang.NullPointerException
      java.lang.NullPointerException
      	at org.folio.circulation.domain.UpdateRequestQueue.updateOutstandingRequestOnCheckIn(UpdateRequestQueue.java:85)
      	at org.folio.circulation.domain.UpdateRequestQueue.onCheckIn(UpdateRequestQueue.java:75)
      	at org.folio.circulation.resources.CheckInProcessAdapter.updateRequestQueue(CheckInProcessAdapter.java:157)
      	at org.folio.circulation.support.results.Result.after(Result.java:252)
      	at org.folio.circulation.support.results.Result.combineAfter(Result.java:124)
      	at org.folio.circulation.resources.CheckInByBarcodeResource.lambda$checkIn$10(CheckInByBarcodeResource.java:86)
      	at java.base/java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:1072)
      	at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:478)
      	at java.base/java.lang.Thread.run(Thread.java:829)
      

      The reason is that item-specific method updateOutstandingRequestOnCheckIn() is called when requestQueue.hasOutstandingFulfillableRequests() (that checks for fulfillable items, not necessarily fulfillable by the same item) returns true.

      Another item-specific method hasOutstandingRequestsFulfillableByItem() needs to be added.

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                sherzod_nurjonov Sherzod Nurjonov
                oleksandrkurash Alexander Kurash
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases