Uploaded image for project: 'mod-circulation'
  1. mod-circulation
  2. CIRC-1371

post to /circulation/requests without request date returns error but changes item status

    XMLWordPrintable

Details

    • EPAM-Veg Sprint 133
    • 3
    • Vega
    • Lotus R1 2022

    Description

      UPDATE (2021-10-04):

      This issue appears to have gotten lost. I've confirmed that the reported behavior still exists and actually occurs if the fulfilmentPreference value is incorrect, as well. For example:

      Attempt to post the following payload to folio-snapshot to replicate the originally-reported behavior:

      {
          "requestType": "Page",
          "fulfilmentPreference": "Hold Shelf",
          "requesterId": "bec20636-fb68-41fd-84ea-2cf910673599",
          "itemId": "23fdb0bc-ab58-442a-b326-577a96204487",
          "pickupServicePointId": "3a40852d-49fd-4df2-a1f9-6e2641a6e91f"
      }
      

      Ensure that the item with barcode: 653285216743 is in status "Available"

      To replicate the issue with "fulfilmentPreference", attempt to post this payload:

      {
          "requestType": "Page",
          "fulfilmentPreference": "Hold shelf",
          "requesterId": "bec20636-fb68-41fd-84ea-2cf910673599",
          "itemId": "23fdb0bc-ab58-442a-b326-577a96204487",
          "pickupServicePointId": "3a40852d-49fd-4df2-a1f9-6e2641a6e91f"
      }
      

      Again, make sure the item is in status "Available"

       

      ORIGINAL REPORT

      If you attempt to create a request without a request date the service returns an error and does NOT create the request but it does change the item status to Paged (for a previously 'available' item)

      To recreate:
      POST to
      http://localhost:9130/circulation/requests
      using an available item without a 'requestDate':

      { "requestType": "Page", "fulfilmentPreference": "Hold Shelf", "requesterId": "99999999-9999-9999-9999-999999999901", "itemId": "e06ed2da-efd2-42a1-b4ca-eae2c672a70a", "pickupServicePointId": "29faacf1-4ba4-42c7-8b2a-566b259e4641" }

      The return is:

      {
      "errors": [{
      "message": "may not be null",
      "type": "1",
      "code": "-1",
      "parameters": [

      { "key": "requestDate", "value": "null" }

      ]
      }]
      }

      However, the item status is changed to Paged

      TestRail: Results

        Attachments

          1. screenshot-1.png
            screenshot-1.png
            60 kB
          2. screenshot-2.png
            screenshot-2.png
            78 kB
          3. screenshot-3.png
            screenshot-3.png
            68 kB

          Issue Links

            Activity

              People

                roman-barannyk Roman Barannyk
                msuranofsky Michelle Suranofsky
                Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases