Uploaded image for project: 'mod-circulation'
  1. mod-circulation
  2. CIRC-1321

Back port missing module permission in fee-fine scheduled notice processing to 2021 R2

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: P2
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 22.0.6
    • Labels:
    • Template:
      Standard Bug Write-Up Format
    • Sprint:
      Prokopovych - Sprint 125, EPAM-Veg Sprint 126
    • Story Points:
      2
    • Development Team:
      Vega
    • Release:
      R2 2021 Hot Fix #4
    • Hot Fix Approved by Cap Planning?:
      Yes
    • RCA Group:
      Missing module permission

      Description

      Background:

      We noticed that certain scheduled notices were not going out in our hosted environments like below:

      { "id": "f6fdc6fc-606c-4acb-a379-894b83507b91", "loanId": "4596bbe0-2496-45ba-a2d1-947ef54e32fb", "feeFineActionId": "73b1809a-f47f-434c-a5c8-53f6852e65fa", "recipientUserId": "e2fbb46b-daa9-4150-90ec-0d0368ac1b77", "nextRunTime": "2021-02-10T16:48:55.603+00:00", "triggeringEvent": "Overdue fine returned", "noticeConfig": { "timing": "Upon At", "templateId": "57e0abbd-a97a-4568-845a-e1b5301ac2ae", "format": "Email", "sendInRealTime": true }, "metadata": { "createdDate": "2021-02-10T16:48:55.777+00:00", "createdByUserId": "bdb3ebcf-d6db-4190-ab93-5201b8925169", "updatedDate": "2021-02-10T16:48:55.777+00:00", "updatedByUserId": "bdb3ebcf-d6db-4190-ab93-5201b8925169" } },
      
      
      

       Noticed messages like the below in logs:

      TenantManager timer call failed to module mod-circulation-19.2.8 for tenant xxx : POST request for mod-circulation-19.2.8 /circulation/fee-fine-scheduled-notices-processing failed with 403: Access requires permission: circulation.rules.notice-policy.get
      
      18:41:17.137 [vert.x-eventloop-thread-0] ERROR mod-auth-authtoken-module - ["inventory-storage.loan-types.item.get","inventory-storage.locations.collection.get","inventory-storage.locations.item.get","inventory-storage.location-units.campuses.item.get","inventory-storage.holdings.item.get","inventory-storage.location-units.institutions.collection.get","accounts.collection.get","feefineactions.collection.get","scheduled-notice-storage.scheduled-notices.item.delete","accounts.item.get","inventory-storage.material-types.collection.get","inventory-storage.material-types.item.get","scheduled-notice-storage.scheduled-notices.collection.get","inventory-storage.items.collection.get","configuration.entries.item.get","configuration.entries.collection.get","inventory-storage.location-units.libraries.collection.get","inventory-storage.service-points.item.get","inventory-storage.service-points.collection.get","inventory-storage.location-units.campuses.collection.get","inventory-storage.location-units.libraries.item.get","inventory-storage.instances.item.get","inventory-storage.instances.collection.get","scheduled-notice-storage.scheduled-notices.item.put","circulation-storage.loans.collection.get","inventory-storage.items.item.get","inventory-storage.holdings.collection.get","inventory-storage.loan-types.collection.get","circulation-storage.loans.item.get","users.item.get","scheduled-notice-storage.scheduled-notices.item.get","feefineactions.item.get","users.collection.get","inventory-storage.location-units.institutions.item.get","patron-notice.post","pubsub.publish.post"](user permissions) nor ["SYS#mod-circulation-19.2.8#/circulation/fee-fine-scheduled-notices-processing#[POST]"](module permissions) do not contain circulation.rules.notice-policy.get
      

       

      On verifying the modulePermissions for https://github.com/folio-org/mod-circulation/blob/v19.2.8/descriptors/ModuleDescriptor-template.json#L746 endpoint, it is missing 'circulation.rules.notice-policy.get' permission

      Actual Results:
      Scheduled notices that have a triggeringEvent of "overdue fine returned" are not going through due to the missing permission

      Expected Results:

      Scheduled notices that have a triggeringEvent of "overdue fine returned" to be sent without failures

      Observations:
      After adding the missing permission, all queued scheduled notices cleared themselves

        TestRail: Results

          Attachments

          1. 2021-10-27_17-57-59.png
            2021-10-27_17-57-59.png
            184 kB
          2. 2021-10-27_18-25-29.png
            2021-10-27_18-25-29.png
            124 kB
          3. 2021-10-27_18-37-20.png
            2021-10-27_18-37-20.png
            52 kB
          4. juniper-log.csv
            71 kB

            Issue Links

              Activity

                People

                Assignee:
                sherzod_nurjonov Sherzod Nurjonov
                Reporter:
                sduvvuri Sobha Duvvuri
                Tester Assignee:
                Julie Bickle Julie Bickle
                Votes:
                0 Vote for this issue
                Watchers:
                11 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    TestRail: Runs

                      TestRail: Cases