Uploaded image for project: 'mod-circulation'
  1. mod-circulation
  2. CIRC-1091

Remove override-renewal-by-barcode endpoint



    • Story
    • Status: Closed (View Workflow)
    • TBD
    • Resolution: Done
    • None
    • 22.0.0
    • None
    • EPAM-Veg Sprint 111, EPAM-Veg Sprint 112, EPAM-Veg Sprint 113, EPAM-Veg Sprint 114, EPAM-Veg Sprint 115
    • 8
    • Vega
    • Large < 10 days
    • Medium


      This is a spillover (technical debt) from R1 "block override" features.

      Currently, only patron block can be overridden with a regular renew-by-barcode endpoint. If there are any other blocks, they need to be overridden by a call to override-renewal-by-barcode (patron block is also overridden in this case).

      All of these blocks need to become a single block that can be overridden with a call to a regular renew-by-barcode endpoint, just like patron block. Functionality of the override-renewal-by-barcode endpoint should be transferred to renew-by-barcode. After that, override-renewal-by-barcode should be removed and all of it's tests should be rewritten to use the new API.

      List of errors that are overridden by override-renewal-by-barcode (taken from FE code) that should be combined to a single block:

      • loan is not renewable
      • item is not loanable
      • item is Declared lost
      • item is Aged to lost
      • renewal date falls outside of date ranges in fixed loan policy
      • items cannot be renewed when there is an active recall request
      • loan at maximum renewal number
      • renewal date falls outside of date ranges in the loan policy
      • renewal would not change the due date
      • profile "" in the loan policy is not recognised

      TestRail: Results


          Issue Links



                roman-barannyk Roman Barannyk
                oleksandrkurash Alexander Kurash
                Alexander Kurash Alexander Kurash
                0 Vote for this issue
                2 Start watching this issue



                  TestRail: Runs

                    TestRail: Cases