Uploaded image for project: 'mod-circulation'
  1. mod-circulation
  2. CIRC-1078

Requesting is not blocked when manual block expiration date is not set

    XMLWordPrintable

Details

    • Standard Bug Write-Up Format
    • EPAM-Veg Sprint 107, EPAM-Veg Sprint 108, EPAM-Veg Sprint 109, EPAM-Veg Sprint 110, EPAM-Veg Sprint 111, EPAM-Veg Sprint 112, EPAM-Veg Sprint 113, EPAM-Veg Sprint 114, EPAM-Veg Sprint 115
    • 1
    • Vega

    Description

      Overview:
      Request creation endpoint /circulation/requests ignores manual patron block if it does not have an expiration date.

      Steps to Reproduce:
      Reproducible only when called directly via API.
      When trying to create a request via UI, manual blocks are checked preemptively and handled correctly by front end.

      • block requesting manually for a user, but do not set block expiration date
      • send a valid POST request to /circulation/requests

      Expected Results:

      • requesting fails, response contains a 422 error: "Patron blocked from requesting"

      Actual Results:

      • request is created successfully, manual patron block is ignored

      Hint for dev:
      UserManualBlocksValidator#isBlockedToCreateRequests

      TestRail: Results

        Attachments

          Activity

            People

              OleksandrVidinieiev Oleksandr Vidinieiev
              OleksandrVidinieiev Oleksandr Vidinieiev
              Darcy Branchini Darcy Branchini
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                TestRail: Runs

                  TestRail: Cases